I had no idea this issue had been identified. While I find this tool very useful, the project is seeming rather questionable to me now.

  • @Antagnostic@lemmy.world
    link
    fedilink
    218
    edit-2
    2 months ago

    I was bored at work one day. I decided to put a nyan cat easter egg in my company’s app. If at the loading progress bar screen you typed NYAN it would turn the progress bar into a rainbow being created by a little nyan cat while playing the nyan cat song. The mp3 (inconspicuously renamed without the extension) doubled our build size. No one batted an eye cause no one paid attention to the build size much.

    Fast forward 5 years later, at a different job, I get a phone call from the old boss. Do you happen to know anything about this nyan cat file we found?

    I had no idea what he was talking about.

    • fmstrat
      link
      fedilink
      English
      632 months ago

      Years and years ago I worked on a project where the logo was the outline of a head and an inward swirl for the brain.

      For the website, if you held your mouse over it for 9 seconds, it would spin and flush. No one ever found that one that I know of.

      • @kautau@lemmy.world
        link
        fedilink
        102 months ago

        It sounds like they weren’t using any form of version control, so that’s definitely on them at this point

        • @Alexstarfire@lemmy.world
          link
          fedilink
          182 months ago

          What makes you say that? To me, it sounds like that’s what they do have cause they tracked the change back to him. The commit message obviously said nothing about the file.

          • @kautau@lemmy.world
            link
            fedilink
            52 months ago

            Ah I could see that. I took it as them not knowing where the file came from at all, so they’re just asking all the devs who would have had access at that point, which is why it was “hey do you know anything about this file?” and not “is there a specific reason you committed this file to the build?”

              • @kautau@lemmy.world
                link
                fedilink
                12 months ago

                You think they’d call up devs who left them just to ask if they happen to know about a random file?

                I mean, that’s what op said happened. Literally with the verbiage of “file we found” and not “file you committed”

  • @mashbooq@lemmy.world
    link
    fedilink
    892 months ago

    After I saw that issue, I attempted to build Ventoy from source. After making numerous modifications and getting only the first couple components built, I got tired of it and quit. I’ve made some modifications to glim and use that instead, although it’s still not as easy as Ventoy. But I don’t trust Ventoy if I can’t build it myself.

    Further, when @vkc@linuxmom.net made some criticisms of Ventoy in one of her YouTube videos, she was subjected to a harassment campaign, and others told her the same happened to them. That pushed me from not trusting Ventoy to actively distrusting it.

    • Snot Flickerman
      link
      fedilink
      English
      462 months ago

      Further, when @vkc@linuxmom.net made some criticisms of Ventoy in one of her YouTube videos, she was subjected to a harassment campaign, and others told her the same happened to them.

      What the fuck is happening to the world? Are we regressing or were we always this regressed and we’ve just given powerful tools to fucking chowderheads?

      • @Telorand@reddthat.com
        link
        fedilink
        392 months ago

        There’s a subset of the Linux/FOSS/etc. community who are Conservative, misogynistic, racist, and/or otherwise general bigots. Compare the Ventoy-bros against the Elon-bros, and you’ll see a similar pattern of behavior.

        I don’t personally understand it, since development is still sometimes seen as “work for weirdo nerds,” so you’d think they would understand what it feels like to be rejected or bullied, but here we are. They manage to stay under the radar, because there’s usually no reason to discuss politics or philosophy when you’re debugging code.

        • Snot Flickerman
          link
          fedilink
          English
          28
          edit-2
          2 months ago

          There’s a subset of the Linux/FOSS/etc. community who are Conservative, misogynistic, racist, and/or otherwise general bigots.

          right, the hackernews set…

          • @WldFyre@lemm.ee
            link
            fedilink
            292 months ago

            Don’t know why you’re being downvoted, hackernews is an awful site of smug, dumb software “engineer” tech bros with some of the worst takes on anything that isn’t explicitly about how to code

      • @aStonedSanta@lemm.ee
        link
        fedilink
        5
        edit-2
        2 months ago

        It’s the other way around I think. We are progressing. More voices are heard which “should” be a good thing. Right? Right…?

        /s

    • @noodlejetski@lemm.ee
      link
      fedilink
      1
      edit-2
      1 month ago

      it’s the opposite, actually: she got harassed because she didn’t talk about it when talking about creating a bootable drive.

  • @n2burns@lemmy.ca
    link
    fedilink
    812 months ago

    I too wish the developer would respond, but I don’t think this is the catastrophe people are making it out to be. One comment seems to explain why these binaries are included:

    Because ventoy supports shim, and by extension secure boot, these files needs to come from a signed Linux distro. In this case they are taken from Fedora releases, and OpenSUSE apparently, as they publish shim binaries and grub binaries signed by their certificate.

      • @Quail4789@lemmy.ml
        link
        fedilink
        English
        242 months ago

        It matters because nobody is going to check the hashes for all of the files match whenever there’s a change so the maintainer can just replace them with whatever he wants.

        • Pup Biru
          link
          fedilink
          English
          252 months ago

          that’s what automation is for - nobody is going to manually check them, but anyone is able to automatically set something up to check their hashes in change… the fact that it’s possible that anyone is doing that now that it’s a known issue perhaps makes it less problematic as an attack vector

            • Pup Biru
              link
              fedilink
              English
              52 months ago

              are you sure?

              there could be thousands just waiting for a failure to come out and say “HEY THIS IS DODGY”

              • @refalo@programming.dev
                link
                fedilink
                1
                edit-2
                2 months ago

                Yea because I tested it myself. Nobody else seems to care, and if they did, I would think there would be a public way to see regular test results regardless.

                I know this exists for some projects, but somehow nothing privacy-sensitive

          • @Quail4789@lemmy.ml
            link
            fedilink
            English
            12
            edit-2
            2 months ago

            The amount of malware you can cram in a source-code patch without drawing attention vs. in a binary is vastly different.

            There’s also the fact that if you want to ship binaries, you can just wget them from source during the build process. Not a perfect solution but much better than what’s ventoy doing. The source code updates works the same in every project because it has to. That’s why this is drawing more attention.

            • @Ferk@lemmy.ml
              link
              fedilink
              3
              edit-2
              2 months ago

              That’s ok if we are talking about malware publicly shown in the published source code… but there’s also the possibility of a private source-code patch with malware that it’s secretly being applied when building the binaries for distribution. Having clean source code in the repo is not a guarantee that the source code is the same that was used to produce the binaries.

              This is why it’s important for builds to be reproducible, any third party should be able to build their own binary from clean source code and be able to obtain the exact same binary with the same hash. If the hashes match, then you have a proof of the binary being clean. You have this same problem with every single binary distribution, even the ones that don’t include pre-compiled binaries in their repo.

              • @refalo@programming.dev
                link
                fedilink
                32 months ago

                The problem is not near enough projects support reproducible builds, and many that do aren’t being regularly verified, at least publicly.

                • @Ferk@lemmy.ml
                  link
                  fedilink
                  1
                  edit-2
                  2 months ago

                  Yes, that’s why im saying that this kind of problem isn’t something particular about this project.

                  In fact I’m not sure if it’s the case that the builds aren’t reproducible/verifiable for these binaries in ventoy. And if they aren’t, then I think it’s in the upstream projects where it should be fixed.

                  Of course ventoy should try to provide traceability for the specific versions they are using, but in principle I don’t think it should be a problem to rely on those binaries if they are verifiable… just the same way as we rely on binaries for many dynamic libraries in a lot of distributions. After all, Ventoy is closer to being an OS/distribution than a particular program.

    • @grue@lemmy.world
      link
      fedilink
      English
      242 months ago

      On the contrary: that just goes to show what a fucking catastrophe for software freedom “Secure[sic] Boot” is.

    • @nialv7@lemmy.world
      link
      fedilink
      172 months ago

      While this is true, it only requires the shim and grub to be copied for another distro.

      From other comments there are a lot more blobs than just these two.

      • davad
        link
        fedilink
        32 months ago

        It sounds like most, if not all, come from upstream projects.

          • davad
            link
            fedilink
            32 months ago

            I think they did say that in the older thread. But for proper security, you shouldn’t have to trust them. You should have build tools that will re-fetch everything to create an identical build. That gives a clear chain of custody, which proves that morning has been tampered with.

    • @infeeeee@lemm.ee
      link
      fedilink
      112 months ago

      It sounds to me as a documentation issue, as the next comment says, simply including a wget script should solve this.

  • @PowerCrazy@lemmy.ml
    link
    fedilink
    English
    612 months ago

    Hey guys open source is great you can look at all the code and therefore there are no security backdoors etc. Also here are a bunch of pre-compiled blobs in the repo, don’t worry about those, but they are required to run the program.

    • snooggums
      link
      fedilink
      English
      912 months ago

      The fact that people know there are pre-compiled blobs in open source means they have an informed reason to avoid the software!

      • @ulkesh@beehaw.org
        link
        fedilink
        English
        42 months ago

        Exactly. Acting like this is an “ah-ha, see?!!” moment when this is exactly what open source is designed for. That’s like saying global warming is a hoax because “oh look it’s snowing”.

        • @PowerCrazy@lemmy.ml
          link
          fedilink
          English
          22 months ago

          This isn’t a knock against opensource programming, but there shouldn’t ever be precompiled blobs in the repo unless they are the official builds for the various OS’s and if you want to build from source, the pre-compiled blobs shouldn’t be part of that, otherwise you can’t really claim you are opensource.

          • @ulkesh@beehaw.org
            link
            fedilink
            English
            12 months ago

            Yes, and that’s what is being called out here. But your original comment makes it sound like you are advocating for closed source software and that somehow open source software is bad.

            This is the system working as intended. When potential issues arise, it’s openly discussed and ideally resolved. And if not, trust is lost and people will stop using it.

            • @PowerCrazy@lemmy.ml
              link
              fedilink
              English
              1
              edit-2
              2 months ago

              I don’t know about the history of the project, but it sounds like those blobs have been there for quite some time. When in reality, the PR that added the blobs in the first place shouldn’t ever have been approved.

              Actually just checked 3+ years.

        • @delirious_owl@discuss.online
          link
          fedilink
          12 months ago

          Well, it is an “ah-ha, see!” moment, because it shows the benefit of open source.

          Its more like pointing at the absence of a glacier on a mountaintop and saying “yep, see, climate change does exist”

          • @ulkesh@beehaw.org
            link
            fedilink
            English
            12 months ago

            I was referring to the commenter and how it read to me :) But agreed, what you said, too.

    • Sem
      link
      fedilink
      English
      282 months ago

      For me the problem is more in GPL violation: they distribute blobs under GPL3, user made a request of the source code by creating an issue, but they ignored that request. It is not only about “you have to fix it” versus “just fork it” imo.

    • @friend_of_satan@lemmy.world
      link
      fedilink
      English
      4
      edit-2
      2 months ago

      Seriously this. Any comment about a complicated system that starts with “just” can be ignored 99% of the time.

      Also, there are 4k forks of Ventoy already. Obviously forking it isn’t helping. Actual work needs to be done.

    • @SatyrSack@lemmy.oneOP
      link
      fedilink
      12 months ago

      I agree that comments like that are unhelpful/unnecessary, but how is that “for their own benefit”? Other than the actual devs themselves using that as a way to just ignore issues, I do not follow

  • Mikelius
    link
    fedilink
    462 months ago

    Glad it’s getting a little more light. Been trying to tell people this for a few years now lol. It’s the reason I’ve stayed away from it since first learning of the tool and looking at the “source code”.

  • monovergent 🏁
    link
    fedilink
    332 months ago

    Makes me wonder how far the closest alternative, glim, could be upgraded to match Ventoy given the confines of GRUB.

    Someone had mentioned that Fedora fails to verify when booting from Ventoy. Now I’m thinking if I could dd the media loaded via Ventoy and compare with an original copy to see what changed.

    • @tetris11@lemmy.ml
      link
      fedilink
      72 months ago

      Little did they know that Patches the Cat bit through their LAN lines and actually increased the cost of their communication.

  • Todd Bonzalez
    link
    fedilink
    282 months ago

    Anyone who wants to fix this can help fix it, but people are just making demands of an unpaid maintainer. The devs can run this project the way they want to. If you don’t like it, don’t use Ventoy.

    The people comparing this to the xz exploit are out of line. xz was a library that was deeply embedded in a lot of software. Ventoy is an IT tool used to boot live OSes. Not even remotely the same attack surface.

    Blobs in the source tree are not ideal, but people need to pick their battles.

    • Lemongrab
      link
      fedilink
      502 months ago

      From what others have said: The blobs violate GPL because they are taken from other FOSS project but the changes Ventoy makes are not viewable.

  • Any alternatives to this tool? I’ve used it a lot lately because I was testing out live OSes before installing one to the hard drive, but otherwise I don’t need it on a daily basis.

    • Snot Flickerman
      link
      fedilink
      English
      232 months ago

      but otherwise I don’t need it on a daily basis.

      I’ll be real, this is part of why I didn’t understand Ventoy. I keep a bunch of large, fast thumbdrives around blank and available. When I need/want to put an OS on there, I do it when I need it, and then I’m always installing the most current version of the install. It takes under 5 minutes, at best.

      I used to try to keep various installs on thumbdrives… but it would be two years down the line by the time I needed to use it again and by that time it’s literally pointless to be using two year old installation media.

      • CoopaLoopa
        link
        fedilink
        222 months ago

        Part of the point behind Ventoy is that you don’t need to prepare the USB to be bootable. You can just copy/paste the whole iso into Ventoy and it will be bootable. New release comes out? Just copy it onto your USB drive. Don’t even need to remove the old version of you don’t want to.

        Makes things much easier in the tech world for having a single USB with 50+ bootable tools and installers on there like with MediCat (which uses Ventoy as a base).

        Only thing I’ve had issues with booting from Ventoy is the ProxMox install iso. Everything else has worked first try.

      • Ventoy wasn’t a foolproof solution but it really did beat the hell out of using 6 different USB drives. Most USB “pen drives” don’t make labeling easy and without labeling I’m just plugging them in one by one till I find the one I want.

        • @mbirth@lemmy.ml
          link
          fedilink
          English
          32 months ago

          I remember various different concepts of USB flash drives with integrated LCDs that would display a label and the remaining capacity. Then they vanished and the only thing left were the Lexar Echo drives. Until a few years ago, when they have been pulled from the markets. Probably, because they didn’t work with the now default GPT and its many different partition types.

      • thejevans
        link
        fedilink
        42 months ago

        When I was working in IT, this would have been a very useful tool for doing some on-site troubleshooting with various tools or for one-off reimaging machines that were missed during a big update or something. Instead, I had a bag of USB sticks with labels on them, which was annoying to use and to maintain.

      • @TheGalacticVoid@lemm.ee
        link
        fedilink
        22 months ago

        As someone with few USBs available, Ventoy takes me 2 minutes to flash, several minutes to copy a set of ISOs, and then any time I need it, it takes 0 minutes to have a working USB with some arbitrary ISO. Sure, it’s not up to date, but I don’t need it to be if I need to recover an install or use some random tool.

    • Ephera
      link
      fedilink
      42 months ago

      I guess, you could buy a handful of USB sticks…

  • Snot Flickerman
    link
    fedilink
    English
    22
    edit-2
    2 months ago

    All my laziness about not checking it out has come to fruition. Now I simply don’t have to, because this is sketch as fuck until it is handled.

    • @Quail4789@lemmy.ml
      link
      fedilink
      English
      102 months ago

      Yep, some people these are saying just 7 of the 150 binaries don’t have source or build info. Yeah, one binary is enough to do all the evil in the world, not that other binaries support reproducible builds anyway.